Drop the dead PrintHeader catch - #153
Conversation
NosCore.Shared 6.0.2 gives PrintHeader a width to fall back on when no console can answer, so nothing reaches the catch that was swallowing it. Tested: builds with 0 warnings, tests green (5 tests).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe launcher now propagates exceptions from ChangesHeader error handling
Shared package update
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change updates startup-banner handling and a patch dependency version without changing the launcher's download or processing workflow; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Title checkExplanation The title accurately describes the removal of the catch around Logger.PrintHeader, which is a real and important part of the pull request. It does not mention the NosCore.Shared package update, but the title need not cover every change. Full details: Docstring CoverageExplanation Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
What
Worker.ExecuteAsyncwrappedLogger.PrintHeaderincatch { // ignored as header is not important }. NosCore.Shared 6.0.2 givesPrintHeadera width to fall back on when no console can answer, so nothing reaches that catch any more and it goes.Pinned 6.0.1 → 6.0.2 for it.
Why the catch existed
Console.WindowWidththrows when no console can answer the screen-buffer question. 6.0.2 decides that with a predicate instead of catching the throw, and — the part that matters for a launcher started from a shell — it also covers the case where stdout and stderr are piped while stdin is still on the console, which 6.0.1 got wrong. Measured, all four console states now print the banner.Testing
Summary by CodeRabbit
Bug Fixes
Chores